Issue 6238 - Fix test_audit_json_logging CI test regression #6264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreynolds389
approved these changes
Jul 16, 2024
mreynolds389
pushed a commit
that referenced
this pull request
Dec 3, 2024
CI test test_audit_json_logging report generation fails because some log file contains non UTF-8 characters. The fix is to ignore invalid characters when generating the report. (So that the logs get properly copied in the assets) Issue #6238 Reviewed by: @mreynolds389 (Thanks!)
mreynolds389
pushed a commit
that referenced
this pull request
Dec 3, 2024
CI test test_audit_json_logging report generation fails because some log file contains non UTF-8 characters. The fix is to ignore invalid characters when generating the report. (So that the logs get properly copied in the assets) Issue #6238 Reviewed by: @mreynolds389 (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI test test_audit_json_logging report generation fails because some log file contains non UTF-8 characters.
The fix is to ignore invalid characters when generating the report.
(So that the logs get properly copied in the assets)
Issue #6238
Reviewed by: @mreynolds389 (Thanks!)