Skip to content

Issue 6245 - Revert __COVERITY__ ifndef #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Jul 17, 2024

PR #6246 generated 300 new coverity scan defect about uninitialized variable because slapi_pblock_get is
within #ifndef COVERITY
Since it generates more warning than it fixes, this change revert this part.

Issue: #6245

Reviewed by: @vashirov , @droideck (Thanks!)

@progier389 progier389 force-pushed the i6248-fix-covscan-regression branch from 4ff3837 to 5ee8dd7 Compare July 18, 2024 09:00
Copy link
Member

@vashirov vashirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progier389 progier389 merged commit 298aa73 into 389ds:main Jul 19, 2024
195 checks passed
@progier389 progier389 deleted the i6248-fix-covscan-regression branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants