Issue 6245 - Fix some other coverity scan regressions #6273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
approved these changes
Aug 8, 2024
lib/libadmin/util.c
Outdated
Comment on lines
154
to
159
| return NULL; | ||
| } | ||
| vals = (char **)MALLOC(sizeof(char *)); | ||
| if (vals == NULL) { | ||
| FREE(vars); | ||
| return NULL; |
There was a problem hiding this comment.
Should we also free cookie before the returns?
There was a problem hiding this comment.
Good catch I missed the STRDUP.
We should also check if STRDUP fails ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some of the new detected issues in
https://scan6.scan.coverity.com/#/project-view/59218/11545?selectedIssue=1558490
Issue: #6245
Reviewed by: @droideck