Issue 6276 - Schema lib389 object is not keeping custom schema data upon editing#6279
Merged
Conversation
droideck
changed the title
tbordaz
approved these changes
Aug 30, 2024
progier389
approved these changes
Aug 30, 2024
progier389
left a comment
progier389
left a comment
Contributor
There was a problem hiding this comment.
It definitively looks nicer with the parametrized fixture ! -:)
LGTM for me but you should better wait for the tests completion and check the result before merging.
…pon editing Description: Fix the condition in _edit_schema_object function, so it corretcly evaluates when we need to set an empty value to schema object. Add tests to cover add and edit Schema operations. Fixes: 389ds#6276 Reviewed by: ?
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 3, 2024
…pon editing (#6279) Description: Fix the condition in the _edit_schema_object function to correctly evaluate when to set an empty value to the schema object. Add tests to cover adding and editing Schema operations. Fixes: #6276 Reviewed by: @tbordaz, @progier389 (Thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix the condition in _edit_schema_object function, so it corretcly evaluates when we need to set an empty value to schema object. Add tests to cover add and edit Schema operations.
Fixes: #6276
Reviewed by: ?