Issue 6280 - Changelog trims updates from a given RID even if a consu… #6281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbordaz
force-pushed
the
issue_6280
branch
2 times, most recently
from
9ee16b0 to
79a8b18
Compare
…mer has not received any of them
Bug description:
If a consumer has not received any of the updates from a given RID, the RUV
(in the replication agreement) contains no csn.
In such case, the changelog trimming thread compute the starting purge csn
using the supplier RUV instead of the RA RUV.
Later the supplier will miss this csn to update the consumer and
replication is broken
Fix description:
The function that iterates the elements of the replication agreement RUV
should call the callback (_cl5EnumConsumerRUV) with all elements even those
containing empty CSN.
The callback (_cl5EnumConsumerRUV) should remove the RID
from the replica RUV in case the RA.RUV is empty.
relates: 389ds#6280
Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
tbordaz
added a commit
that referenced
this pull request
Aug 26, 2024
…mer has not received any of them (#6281) Bug description: If a consumer has not received any of the updates from a given RID, the RUV (in the replication agreement) contains no csn. In such case, the changelog trimming thread compute the starting purge csn using the supplier RUV instead of the RA RUV. Later the supplier will miss this csn to update the consumer and replication is broken Fix description: The function that iterates the elements of the replication agreement RUV should call the callback (_cl5EnumConsumerRUV) with all elements even those containing empty CSN. The callback (_cl5EnumConsumerRUV) should remove the RID from the replica RUV in case the RA.RUV is empty. relates: #6280 Reviewed by: Pierre Rogier, Simon Pichugin (Thanks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mer has not received any of them
Bug description:
If a consumer has not received any of the updates from a given RID, the RUV
(in the replication agreement) contains no csn.
In such case, the changelog trimming thread compute the starting purge csn
using the supplier RUV instead of the RA RUV.
Later the supplier will miss this csn to update the consumer and
replication is broken
Fix description:
The function that iterates the elements of the replication agreement RUV
should call the callback (_cl5EnumConsumerRUV) with all elements even those
containing empty CSN.
The callback (_cl5EnumConsumerRUV) should remove the RID
from the replica RUV in case the RA.RUV is empty.
relates: #6280
Reviewed by: