Issue 6282 - BUG - out of tree build fails #6283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: When building with an external builddir the build fails. Fix Description: Due to how python setup.py works, we have to specifically template it into srcdir rather than the build dir. Rename cargo/config to cargo/config.toml to avoid future build errors. fixes: 389ds#6282 Author: William Brown <william@blackhats.net.au> Review by: ???
|
@vashirov Any issues with this in 2.5? Seems like we need it there for SUSE. |
|
No issues, should be fine. |
Firstyear
added a commit
that referenced
this pull request
Aug 2, 2024
Bug Description: When building with an external builddir the build fails. Fix Description: Due to how python setup.py works, we have to specifically template it into srcdir rather than the build dir. Rename cargo/config to cargo/config.toml to avoid future build errors. fixes: #6282 Author: William Brown <william@blackhats.net.au> Review by: @vashirov (Thanks!)
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: When building with an external builddir the build fails.
Fix Description: Due to how python setup.py works, we have to specifically template it into srcdir rather than the build dir.
Rename cargo/config to cargo/config.toml to avoid future build errors.
fixes: #6282
Author: William Brown william@blackhats.net.au
Review by: ???