Skip to content

Issue 6301 - Fix long delay when setting replication agreement with dsconf #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

droideck
Copy link
Member

Bug Description:
When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after.

Fixes: #6301

Reviewed by: ?

…dsconf

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: 389ds#6301

Reviewed by: ?
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a minor point

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@droideck droideck merged commit e2495b1 into 389ds:main Aug 27, 2024
190 of 195 checks passed
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
droideck added a commit that referenced this pull request Aug 27, 2024
…dsconf (#6303)

Bug Description:
When creating a replication agreement using dsconf, the command line would get
stuck for approximately 65 seconds. This delay did not occur when creating and
initializing the agreement through the WebUI.

Fix Description:
The fix implements an "atomic" approach by performing the initialization at the
point of agreement creation entry, rather than as a separate step immediately
after.

Fixes: #6301

Reviewed by: @progier389 @tbordaz (Thank you!)
@droideck
Copy link
Member Author

droideck commented Aug 27, 2024

a9cbacd..2cf519d 389-ds-base-3.0 -> 389-ds-base-3.0
bd7ca1e..776f0e2 389-ds-base-2.5 -> 389-ds-base-2.5
8edf050..7bdd19c 389-ds-base-2.4 -> 389-ds-base-2.4
4a1c4ba..ebdbf2e 389-ds-base-2.3 -> 389-ds-base-2.3
1bd3666..e11fb32 389-ds-base-2.2 -> 389-ds-base-2.2
387c9b8..66550f0 389-ds-base-2.1 -> 389-ds-base-2.1
9458387..27daab1 389-ds-base-2.0 -> 389-ds-base-2.0
976acfd..0c184e1 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long delay when setting replication agreement through command line with dsconf
3 participants