Issue 6301 - Fix long delay when setting replication agreement with dsconf - #6303
Merged
Conversation
…dsconf Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: 389ds#6301 Reviewed by: ?
progier389
approved these changes
Aug 21, 2024
progier389
left a comment
progier389
left a comment
Contributor
There was a problem hiding this comment.
Looks good except a minor point
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…dsconf (#6303) Bug Description: When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI. Fix Description: The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after. Fixes: #6301 Reviewed by: @progier389 @tbordaz (Thank you!)
Member
Author
|
a9cbacd..2cf519d 389-ds-base-3.0 -> 389-ds-base-3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description:
When creating a replication agreement using dsconf, the command line would get stuck for approximately 65 seconds. This delay did not occur when creating and initializing the agreement through the WebUI.
Fix Description:
The fix implements an "atomic" approach by performing the initialization at the point of agreement creation entry, rather than as a separate step immediately after.
Fixes: #6301
Reviewed by: ?