Issue 6307 - Wrong set of entries returned for some search filters#6308
Merged
Conversation
Contributor
Author
|
Thanks @progier389 for the review, I will write a CI test before pushing it. |
tbordaz
force-pushed
the
issue_6307
branch
3 times, most recently
from
fcb2262 to
0f2ed2d
Compare
Bug description:
When the server returns an entry to a search it
checks both access and matching of the filter.
When evaluating a '!' (NOT) logical expression the server,
in a first phase evaluates ONLY the right to access the
related component (and its subcomponents).
Then in a second phase verifies the matching.
If the related component is a OR, in the first phase it
evaluates access AND matching, this even if the call was
to evaluate only access.
This result in incoherent results.
Fix description:
Make sure that when the function vattr_test_filter_list_or
is called to only check access, it does not evaluate the matching.
fixes: 389ds#6307
Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
tbordaz
added a commit
that referenced
this pull request
Sep 5, 2024
…6308) Bug description: When the server returns an entry to a search it checks both access and matching of the filter. When evaluating a '!' (NOT) logical expression the server, in a first phase evaluates ONLY the right to access the related component (and its subcomponents). Then in a second phase verifies the matching. If the related component is a OR, in the first phase it evaluates access AND matching, this even if the call was to evaluate only access. This result in incoherent results. Fix description: Make sure that when the function vattr_test_filter_list_or is called to only check access, it does not evaluate the matching. fixes: #6307 Reviewed by: Pierre Rogier (Thanks !!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
When the server returns an entry to a search it
checks both access and matching of the filter.
When evaluating a '!' (NOT) logical expression the server,
in a first phase evaluates ONLY the right to access the
related component (and its subcomponents).
Then in a second phase verifies the matching.
If the related component is a OR, in the first phase it
evaluates access AND matching, this even if the call was
to evaluate only access.
This result in incoherent results.
Fix description:
Make sure that when the function vattr_test_filter_list_or
is called to only check access, it does not evaluate the matching.
relates: # 6307
Reviewed by: