Issue 5843 - Fix size formatting in dscreate output and enhance tests#6309
Merged
Conversation
Description: Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs. Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions. Relates: 389ds#5843 Reviewed by: ?
droideck
added a commit
that referenced
this pull request
Aug 27, 2024
…#6309) Description: Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs. Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions. Relates: #5843 Reviewed by: @progier389 (Thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix the size formatting in
get_default_mdb_max_sizewithinutils.pyto ensuredscreatedisplays the correct value in both interactive and create-template installs. Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.Relates: #5843
Reviewed by: ?