-
Notifications
You must be signed in to change notification settings - Fork 103
Issue 6090 - Fix dbscan options and man pages #6315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed several issues because the testcase failed on bdb:
|
tbordaz
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor question else LGTM
droideck
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All really minor issues
50105c2 to
3a48002
Compare
progier389
added a commit
that referenced
this pull request
Oct 7, 2024
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16)
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16)
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16) (cherry picked from commit 4790bfe)
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16) (cherry picked from commit 4790bfe) (cherry picked from commit 2ce6458)
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit 2ce6458.
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16)
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
progier389
added a commit
that referenced
this pull request
Jan 30, 2025
* Issue 6090 - Fix dbscan options and man pages dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database (cf issue #5609 ). This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content. The fix should also align both the usage and the dbscan man page with the new set of options Issue: #6090 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit 25e1d16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbscan -d option is dangerously confusing as it removes a database instance while in db_stat it identify the database
(cf issue #5609 ).
This fix implements long options in dbscan, rename -d in --remove, and requires a new --do-it option for action that change the database content.
The fix should also align both the usage and the dbscan man page with the new set of options
Issue: #6090
Reviewed by: @tbordaz, @droideck (Thanks!)