Issue 6321 - lib389 get_db_lib function may returns the wrong db type#6322
Merged
Conversation
Contributor
Author
|
Added a test case and realized that there was also a problem in the off line case. |
progier389
added
the
work in progress
Contributor
Author
|
Hum, |
progier389
removed
the
work in progress
Contributor
Author
|
Commited new version with parametrized test (which is indeed simpler) |
vashirov
pushed a commit
that referenced
this pull request
Apr 23, 2025
…#6322) * Issue 6321 - lib389 get_db_lib function may returns the wrong db type get_db_lib returns the default db type instead of the configured one because of caught exceptions Fix the import issue if instance is online Fix the DSEldif parameter for the offline case Issue: #6321 Reviewed by: @tbordaz (Thanks!)
vashirov
pushed a commit
that referenced
this pull request
Apr 23, 2025
…#6322) * Issue 6321 - lib389 get_db_lib function may returns the wrong db type get_db_lib returns the default db type instead of the configured one because of caught exceptions Fix the import issue if instance is online Fix the DSEldif parameter for the offline case Issue: #6321 Reviewed by: @tbordaz (Thanks!)
vashirov
pushed a commit
that referenced
this pull request
Apr 23, 2025
…#6322) * Issue 6321 - lib389 get_db_lib function may returns the wrong db type get_db_lib returns the default db type instead of the configured one because of caught exceptions Fix the import issue if instance is online Fix the DSEldif parameter for the offline case Issue: #6321 Reviewed by: @tbordaz (Thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_db_lib returns the default db type instead of the configured one because of caught exceptions
Fix the import issue if instance is online
Fix the DSEldif parameter for the offline case
Issue: #6321
Reviewed by: @tbordaz (Thanks!)