Issue 6345 - Ensure all slapi_log_err calls end format strings with newline character \n#6346
Merged
droideck merged 2 commits into389ds:mainfrom Sep 28, 2024
Merged
Issue 6345 - Ensure all slapi_log_err calls end format strings with newline character \n#6346droideck merged 2 commits into389ds:mainfrom
droideck merged 2 commits into389ds:mainfrom
Conversation
…ewline character \n Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: 389ds#6345 Reviewed by: ?
tbordaz
reviewed
Sep 26, 2024
Contributor
tbordaz
left a comment
tbordaz
left a comment
There was a problem hiding this comment.
Fix looks good. Just one question
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
droideck
added a commit
that referenced
this pull request
Sep 28, 2024
…ewline character \n (#6346) Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos. Fixes: #6345 Reviewed by: @progier389, @tbordaz (Thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos.
Fixes: #6345
Reviewed by: ?