Issue 6243 - dsctl bdb2mdb should cleanly fail if bundled libdb is not available - #6351
Conversation
| return BDB_IMPL_STATUS.READ_ONLY | ||
| if pkgs[BDB_RPM] is not False and symbs[BDB_SYMBOL] is True: | ||
| return BDB_IMPL_STATUS.RPM | ||
| if symbs[BDB_SYMBOL] is False and pkgs[BDB_BUNDLED_RPM] is False: |
There was a problem hiding this comment.
I think at this step pkgs[BDB_BUNDLED_RPM] is false so we may not test it.
Why if we have not the bdb symbols should we fallback to NONE. Having BDB_RPM is not enough to decide it is RPM ?
There was a problem hiding this comment.
No. FYI: the values have a 3 way logic: True,False or None (if we are not able to determine if
the rpm is installed or not ==> not True does not mean False
No if ds389 is build to use Bundle RPM or Read-Obly bdb, even if someone somehow install libdb it will not be used because the backend is not linked with libdb ...
| BDB_SYMBOL = 'bdb_start' | ||
| TESTED_SYMBOLS = ( BDB_SYMBOL, BDBRO_SYMBOL ) | ||
|
|
||
| OBJDUMP_TOOL = '/usr/bin/objdump' |
There was a problem hiding this comment.
objdump is part of binutils. In a proper prod environment it should not be present on the system.
| for ppath in glob.glob(f'{pdir}/libback-ldbm.*'): | ||
| plugin = ppath | ||
| if plugin and os.path.isfile(OBJDUMP_TOOL): | ||
| rc = subprocess.run(['objdump', '-R', plugin], text=True, capture_output=True) |
There was a problem hiding this comment.
Instead of testing for symbols, can we make a decision about type of libdb based on /proc/$(pidof ns-slapd)/maps contents?
For example:
- bundled libdb
grep libdb /proc/$(pidof ns-slapd)/maps
7fdd4d9eb000-7fdd4da0f000 r--p 00000000 fd:02 4623526 /usr/lib64/dirsrv/libdb-5.3-389ds.so
7fdd4da0f000-7fdd4db61000 r-xp 00024000 fd:02 4623526 /usr/lib64/dirsrv/libdb-5.3-389ds.so
7fdd4db61000-7fdd4dba7000 r--p 00176000 fd:02 4623526 /usr/lib64/dirsrv/libdb-5.3-389ds.so
7fdd4dba7000-7fdd4dbb1000 r--p 001bb000 fd:02 4623526 /usr/lib64/dirsrv/libdb-5.3-389ds.so
7fdd4dbb1000-7fdd4dbb2000 rw-p 001c5000 fd:02 4623526 /usr/lib64/dirsrv/libdb-5.3-389ds.so
- system libdb
grep libdb /proc/$(pidof ns-slapd)/maps
ffffa5470000-ffffa549b000 r--p 00000000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa549b000-ffffa54a0000 ---p 0002b000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa54a0000-ffffa55d4000 r-xp 00030000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa55d4000-ffffa55e0000 ---p 00164000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa55e0000-ffffa562a000 r--p 00170000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa562a000-ffffa5636000 ---p 001ba000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa5636000-ffffa5640000 r--p 001c6000 fd:00 1181522 /usr/lib64/libdb-5.3.so
ffffa5640000-ffffa5641000 rw-p 001d0000 fd:00 1181522 /usr/lib64/libdb-5.3.so
And with no libdb available (or if it's already an instance with mdb), there wouldn't be any output.
The only caveat is that the instance needs to be running...
There was a problem hiding this comment.
Interesting idea,. IMHO we can even keep the benefit of both solutions:
Keep current code and if status is UNKNOWN then try to get the process maps
Another solution would be to use ldd on libback-ldbm.so since ldd is provided by glibc-common that should always be installed
|
Here is a version that directly for strings in libback-ldbm.so binary (without needing any tools) |
progier389
added
the
work in progress
|
Fixed two issues:
|
progier389
removed
the
work in progress
droideck
left a comment
droideck
left a comment
There was a problem hiding this comment.
Besides the minor issue, looks good!
| return BDB_IMPL_STATUS.READ_ONLY | ||
| if plgstrs[libdb] is True: | ||
| # standard bdb package build | ||
| return BDB_IMPL_STATUS.STABDARD |
There was a problem hiding this comment.
Probably a type (STANDARD?).
Also, it's not in src/lib389/lib389/_constants.py, I think.
There was a problem hiding this comment.
👍 Good catch! i fixed the typo and renamed RPM into STANDARD in the Enum definition.
…t available (#6351) Issue 6243 - dsctl bdb2mdb should cleanly fail if bundled libdb is not avaiable Determine what kind of Berkeley Database library is available and display a clear error message if it is not available or not usable Issue: #6243 Reviewed by: @tbordaz , @vashirov , @droideck (Thanks!) (cherry picked from commit 92eadd1)
4 participants
Determine what kind of Berkeley Database library is available
and display a clear error message if it is not available or not usable
Issue: #6243
Reviewed by: @tbordaz , @vashirov , @droideck (Thanks!)