Skip to content

Issue 6339 - Address Coverity scan issues in memberof and bdb_layer#6353

Merged
droideck merged 2 commits into
389ds:mainfrom
droideck:i6339
Oct 4, 2024
Merged

Issue 6339 - Address Coverity scan issues in memberof and bdb_layer#6353
droideck merged 2 commits into
389ds:mainfrom
droideck:i6339

Conversation

@droideck

@droideck droideck commented Oct 3, 2024

Copy link
Copy Markdown
Member

Description: Add null check for memberof attribute in memberof.c
Fix memory leak by freeing 'cookie' in memberof.c
Add null check for database environment in bdb_layer.c
Fix race condition by adding mutex lock/unlock in bdb_layer.c

Fixes: #6339

Reviewed by: ?

Description: Add null check for memberof attribute in memberof.c
Fix memory leak by freeing 'cookie' in memberof.c
Add null check for database environment in bdb_layer.c
Fix race condition by adding mutex lock/unlock in bdb_layer.c

Fixes: 389ds#6339

Reviewed by: ?

@progier389 progier389 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbscan is broken

Comment thread ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c

@tbordaz tbordaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memberof part LGTM

Comment thread ldap/servers/plugins/memberof/memberof.c

@progier389 progier389 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droideck droideck merged commit 60289c9 into 389ds:main Oct 4, 2024
droideck added a commit that referenced this pull request Jul 30, 2025
…6353)

Description: Add null check for memberof attribute in memberof.c
Fix memory leak by freeing 'cookie' in memberof.c
Add null check for database environment in bdb_layer.c
Fix race condition by adding mutex lock/unlock in bdb_layer.c

Fixes: #6339

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Jul 30, 2025
…6353)

Description: Add null check for memberof attribute in memberof.c
Fix memory leak by freeing 'cookie' in memberof.c
Add null check for database environment in bdb_layer.c
Fix race condition by adding mutex lock/unlock in bdb_layer.c

Fixes: #6339

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Jul 30, 2025
…6353)

Description: Add null check for memberof attribute in memberof.c
Fix memory leak by freeing 'cookie' in memberof.c
Add null check for database environment in bdb_layer.c
Fix race condition by adding mutex lock/unlock in bdb_layer.c

Fixes: #6339

Reviewed by: @progier389, @tbordaz (Thanks!)
@droideck droideck deleted the i6339 branch January 15, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coverity scan issue in new deferred memberof code

3 participants