Issue 6328 - vlv control may not be logged#6354
Merged
Merged
Conversation
droideck
approved these changes
Oct 4, 2024
Member
droideck
left a comment
droideck
left a comment
There was a problem hiding this comment.
The code looks good to me!
However, I'm slightly concerned about potential performance impact...
Maybe we could add an on/off switch for detailed VLV logging?
But if you've already checked and it's not really slowing things down, then nevermind!
Contributor
Author
|
About the performance concern: |
progier389
added a commit
that referenced
this pull request
Oct 18, 2024
VLV control is logged only after succesfully sending the VLV response control which means that VLV is not visible if the search fail which make troubleshooting harder. This fix, logs the VLV (with None as vlv result) everytime a VLV is used This fix also improve lmdb debug log about VLVs Issue: #6328 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit b808a2d)
progier389
added a commit
that referenced
this pull request
Oct 18, 2024
VLV control is logged only after succesfully sending the VLV response control which means that VLV is not visible if the search fail which make troubleshooting harder. This fix, logs the VLV (with None as vlv result) everytime a VLV is used This fix also improve lmdb debug log about VLVs Issue: #6328 Reviewed by: @tbordaz, @droideck (Thanks!) (cherry picked from commit b808a2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VLV control is logged only after succesfully sending the VLV response control
which means that VLV is not visible if the search fail which make troubleshooting harder.
This fix, logs the VLV (with None as vlv result) everytime a VLV is used
This fix also improve lmdb debug log about VLVs
Issue: #6328
Reviewed by: @tbordaz, @droideck (Thanks!)