Issue 6347 - better fix for desyncronized vlv cache#6358
Merged
progier389 merged 1 commit into389ds:mainfrom Oct 10, 2024
Merged
Issue 6347 - better fix for desyncronized vlv cache#6358progier389 merged 1 commit into389ds:mainfrom
progier389 merged 1 commit into389ds:mainfrom
Conversation
tbordaz
approved these changes
Oct 9, 2024
Contributor
tbordaz
left a comment
tbordaz
left a comment
There was a problem hiding this comment.
Only cosmetic points. LGTM
| dladdr(fn, &info); | ||
| /* Cannot use dbi_str here because slot is not yet up2date (so dbname is an argument) */ | ||
| dbg_log(file, lineno, funcname, DBGMDB_LEVEL_MDBAPI, "%s(txn=0x%p, dbi=%d <%s>, fn=0x%p <%s>)\n", action, txn, dbi, dbname, fn, info.dli_sname); | ||
| dbg_log(file, lineno, funcname, DBGMDB_LEVEL_MDBAPI, "%s(txn=0x%p, dbi=%d <%s>, fn=0x%p <%s>)\n", action, txn, dbi, dbname, fn, info.dli_sname); |
Contributor
There was a problem hiding this comment.
Why not calling txn_loglvl() instead of DBGMDB_LEVEL_MDBAPI?
Contributor
Author
There was a problem hiding this comment.
txn_log() is used only for txn related function It allows to log when txn are open and closed when
DBGMDB_LEVEL_MDBAPI or DBGMDB_LEVEL_TXN is set but log txn backtrace only if DBGMDB_LEVEL_TXN is set
| if (rc) { | ||
| break; | ||
| } | ||
| if (recno % RECNO_CACHE_INTERVAL == 1) { |
Contributor
There was a problem hiding this comment.
Is it good indentation here ?
progier389
added a commit
that referenced
this pull request
Oct 10, 2024
A better fix than PR 6349 about corrupted vlv cache Problem is a race condition because txn was released while building the cache. Solution keep the write txn open until the cache is fully rebuilt. Also fixed some debug logs And also added the source of a tool useful to check the vlv cache consistency Note: this remove PR #6349 and integrate PR #6356 Issue: #6347 Reviewed by @tbodaz (Thanks!) (cherry picked from commit 8366819)
progier389
added a commit
that referenced
this pull request
Oct 11, 2024
A better fix than PR 6349 about corrupted vlv cache Problem is a race condition because txn was released while building the cache. Solution keep the write txn open until the cache is fully rebuilt. Also fixed some debug logs And also added the source of a tool useful to check the vlv cache consistency Note: this remove PR #6349 and integrate PR #6356 Issue: #6347 Reviewed by @tbodaz (Thanks!) (cherry picked from commit 8366819)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A better fix than PR 6349 about corrupted vlv cache
Problem is a race condition because txn was released while building the cache.
Solution keep the write txn open until the cache is fully rebuilt.
Also fixed some debug logs
And also added the source of a tool useful to check the vlv cache consistency
Note: this remove PR #6349 and integrate PR #6356
Issue: #6347
Reviewed by @tbodaz (Thanks!)