Skip to content

Issue 6067 - Update dsidm to prioritize basedn from .dsrc over interactive input #6362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

droideck
Copy link
Member

Description: Modify dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: ?

…ctive input

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: 389ds#6067

Reviewed by: ?
Copy link
Contributor

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this is a really good way to handle this :)

@Firstyear
Copy link
Contributor

If it's not too much trouble, can we back port this to 2.2?

@droideck droideck merged commit ffb9e8a into 389ds:main Oct 17, 2024
196 of 197 checks passed
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
droideck added a commit that referenced this pull request Oct 17, 2024
…ctive input (#6362)

Description: Modifies dsidm CLI tool to check for the basedn in the .dsrc configuration file
when the -b option is not provided.
Previously, users were required to always specify the basedn interactively if -b was omitted,
even if it was available in .dsrc.
Now, the basedn is determined by first checking the -b option, then the .dsrc file, and finally
prompting the user if neither is set.

Related: #6067

Reviewed by: @Firstyear (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants