Issue 6375 - UI - Update cockpit.js code to the latest version

[droideck]

Description: Update src/cockpit/389-console/pkg/lib/cockpit.js to the latest version.
Update the entire src/cockpit/389-console/pkg/lib directory from Cockpit's repository.
Update package.json.

Fixes: #6375

Reviewed by: ?

[droideck]

Okay, I've tried to do this without the Patternfly 4 -> 5 upgrade, and it didn't work correctly.
The porting should not be very hard, but it's a bit time-consuming. Select and table components are the main issues:
https://www.patternfly.org/get-started/upgrade/

I'll be back from PTO in 10 days. If we need it sooner, feel free to continue the PR. Otherwise, I'll finish when I return.

[progier389]

Although I have not found anything suspicious,
because of the amount of changes, it is quite hard to understand the global impact.
So my feeling is that we should go ahead and merge this PR then fully test cockpit again.

[droideck]

Although I have not found anything suspicious, because of the amount of changes, it is quite hard to understand the global impact. So my feeling is that we should go ahead and merge this PR then fully test cockpit again.

I still need to finish Tables. We have a lot of warnings otherwise (and the migration script complains about elements, even though generally, tables-deprecated works)

So I first finish all of the tables, and then we can merge and test it, yep...

[droideck]

Okay, it's ready for review!
P.S. I still need to replace FontAwesomeIcons as they throw warnings but it should not affect other content review.

[mreynolds389]

Not sure how you want to handle this, but your new tables seem to be missing the "compact" setting

--- a/src/cockpit/389-console/src/lib/server/errorLog.jsx
+++ b/src/cockpit/389-console/src/lib/server/errorLog.jsx
@@ -501,7 +501,7 @@ export class ServerErrorLog extends React.Component {
     handleOnSelect = (_event, isSelected, rowIndex) => {
         let disableSaveBtn = true;
         const rows = [...this.state.rows];
-        
+
         // Update the selected row
         rows[rowIndex].selected = isSelected;
 
@@ -596,6 +596,7 @@ export class ServerErrorLog extends React.Component {
                             <Table
                                 aria-label="Selectable Error Log Levels"
                                 className="ds-left-margin"
+                                variant="compact"
                             >
                                 <Thead>
                                     <Tr>

Not every table "is compact" but I think almost all of them were:

variant={TableVariant.compact}   --->   variant="compact"

It might be easier to fix this now than in a different PR. Thoughts?

[mreynolds389]

Browser crash

Monitor -> Database -> "dc=example,dc=com":

suffixMonitor.jsx:166 Uncaught TypeError: Cannot read properties of undefined (reading '0')
    at Function.<anonymous> (suffixMonitor.jsx:166:50)
    at process_queue (deferred.js:124:33)
    at deferred.js:137:31
    at later_drain (deferred.js:18:9)

Also, it looks like most of the tables are compact, so maybe it's just the logging level tables?

[mreynolds389]

Browser crash

Monitor -> Database -> "dc=example,dc=com":

suffixMonitor.jsx:166 Uncaught TypeError: Cannot read properties of undefined (reading '0')
    at Function.<anonymous> (suffixMonitor.jsx:166:50)
    at process_queue (deferred.js:124:33)
    at deferred.js:137:31
    at later_drain (deferred.js:18:9)

Ok this was not a regression in your patch. This is also crashing in main (bdb vs mdb issue)

[mreynolds389]

Please update the logging level tables to be compact, and double check there are no more tables that might be missing the compact variant. Otherwise looks good!!

[droideck]

It might be easier to fix this now than in a different PR. Thoughts?

Sounds good!

Ok this was not a regression in your patch. This is also crashing in main (bdb vs mdb issue)

Yeah, it won't be one line fix, MDB/BDB wise, - we'll need another PR.

As for this, changes are done... Please, review:)