Skip to content

Issue 6377 - syntax error in setup.py #6378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Oct 22, 2024

Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progier389 progier389 linked an issue Oct 22, 2024 that may be closed by this pull request
@progier389 progier389 merged commit 118a7f9 into 389ds:main Oct 22, 2024
196 of 197 checks passed
progier389 added a commit that referenced this pull request Oct 22, 2024
Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)

(cherry picked from commit 118a7f9)
@Firstyear
Copy link
Contributor

I saw this on some 2.0 branches and 3.1, so I think it needs to be backported too.

@progier389
Copy link
Contributor Author

😕 Sorry but I am lost: I do not see any 3.1 branches:

git pull
Already up to date.
git branch -a | grep remotes/origin/389-ds-base-3 
  remotes/origin/389-ds-base-3.0

and cli_ctl/dblib.py does not exist in origin/389-ds-base-2.0 branch

Furthermore git log shows that
Issue 6064 - bdb2mdb shows errors (#6341) is in 389-ds-base-3.0 branch
but not in 389-ds-base-2.5 branch ...

@Firstyear
Copy link
Contributor

I might just be confused :)

@progier389 progier389 deleted the i6377 branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in setup.py.in
4 participants