Skip to content

Issue 6377 - syntax error in setup.py#6378

Merged
progier389 merged 1 commit into389ds:mainfrom
progier389:i6377
Oct 22, 2024
Merged

Issue 6377 - syntax error in setup.py#6378
progier389 merged 1 commit into389ds:mainfrom
progier389:i6377

Conversation

@progier389
Copy link
Copy Markdown
Contributor

@progier389 progier389 commented Oct 22, 2024 •
edited
Loading

Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)

tbordaz
tbordaz approved these changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progier389 progier389 linked an issue Oct 22, 2024 that may be closed by this pull request
Syntax error in setup.py.in #6377
Closed
@progier389 progier389 merged commit 118a7f9 into 389ds:main Oct 22, 2024
progier389 added a commit that referenced this pull request Oct 22, 2024
@progier389
Issue 6377 - syntax error in setup.py (#6378)
86e2e63 
Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)

(cherry picked from commit 118a7f9)
@Firstyear
Copy link
Copy Markdown
Contributor

Firstyear commented Oct 22, 2024

I saw this on some 2.0 branches and 3.1, so I think it needs to be backported too.

@progier389
Copy link
Copy Markdown
Contributor Author

progier389 commented Oct 23, 2024

😕 Sorry but I am lost: I do not see any 3.1 branches:

git pull
Already up to date.
git branch -a | grep remotes/origin/389-ds-base-3 
  remotes/origin/389-ds-base-3.0

and cli_ctl/dblib.py does not exist in origin/389-ds-base-2.0 branch

Furthermore git log shows that
Issue 6064 - bdb2mdb shows errors (#6341) is in 389-ds-base-3.0 branch
but not in 389-ds-base-2.5 branch ...

@Firstyear
Copy link
Copy Markdown
Contributor

Firstyear commented Oct 25, 2024

I might just be confused :)

@progier389 progier389 deleted the i6377 branch May 20, 2025 13:05
vashirov pushed a commit that referenced this pull request Jun 30, 2025
@progier389 @vashirov
Issue 6377 - syntax error in setup.py (#6378)
0c79797 
Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)
vashirov pushed a commit that referenced this pull request Jun 30, 2025
@progier389 @vashirov
Issue 6377 - syntax error in setup.py (#6378)
1ad2825 
Syntax error due to badly nested quotes in dblib.py cause trouble in setup.py and dsconf dblib b2b2mdb/mdb2dbd
Fix bit using double quotes in the f-expression and quotes for the embedded strings.

Issue: #6377

Reviewed by: @tbordaz, @droideck (Thank!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbordaz tbordaz tbordaz approved these changes

@droideck droideck droideck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Syntax error in setup.py.in

4 participants

@progier389 @Firstyear @tbordaz @droideck