-
Notifications
You must be signed in to change notification settings - Fork 103
Issue 6386 - backup/restore broken after db log rotation #6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1e96b9 to
d0334ed
Compare
mreynolds389
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, Ack!
tbordaz
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
progier389
added a commit
that referenced
this pull request
Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database. Solution is to remove all existing log files before copying the backuped files. Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed. Issue: #6386 Reviewed by: @mreynolds389, @tbordaz (Thanks!) (cherry picked from commit a48be7b) (cherry picked from commit 0c8829b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.
Issue: #6386
Reviewed by: @mreynolds389, @tbordaz (Thanks!)