Skip to content

Issue 6386 - backup/restore broken after db log rotation #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Nov 14, 2024

Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

@progier389 progier389 force-pushed the i6386 branch 2 times, most recently from e1e96b9 to d0334ed Compare November 14, 2024 17:31
Copy link
Contributor

@mreynolds389 mreynolds389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Ack!

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@progier389 progier389 merged commit a48be7b into 389ds:main Nov 15, 2024
195 of 197 checks passed
@progier389 progier389 linked an issue Nov 15, 2024 that may be closed by this pull request
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
progier389 added a commit that referenced this pull request Jan 14, 2025
Restore does fail if the db log file have rotated since the backup. The reason is that the current log files are not removed mixing old and new log file which confuse the database.
Solution is to remove all existing log files before copying the backuped files.
Note: the number of db region should not change and having an extra db file should not be a problem so only the log files must be removed.

Issue: #6386

Reviewed by: @mreynolds389, @tbordaz (Thanks!)

(cherry picked from commit a48be7b)
(cherry picked from commit 0c8829b)
@progier389 progier389 deleted the i6386 branch May 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup/restore broken after bdb txn log rotation
3 participants