Issue 6349 - RFE - extract keys once (#6363) (#6394) #6413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing with replicas all afternoon killing and starting them to check this and it seems happier. So sorry this has been such a pain :( |
progier389
reviewed
Nov 21, 2024
Yes, it should point to an issue #6340. |
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: 389ds#6340 Author: William Brown <william@blackhats.net.au> Review by: ???
Firstyear
force-pushed
the
20241121-can-this-finally-be-done
branch
from
9896218 to
90fb098
Compare
|
Fixed up both issue. So sorry to have missed this, it was a very long day :( |
|
Hey @Firstyear, I'm preparing new upstream releases and would like to include this fix as well. |
|
Yep, can do. |
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation. I really hope I got it right this time :( fixes: #6340 Author: William Brown <william@blackhats.net.au> Review by: @progier389 @vashirov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: Keys/Certs are extracted to PEM
repeatedly causing many warnings during outbound TLS authenticated replication
Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation.
I really hope I got it right this time :(
fixes: #6340
Author: William Brown william@blackhats.net.au
Review by: ???