Issue 6415 - BUG - Incorrect icu linking#6416
Merged
Merged
Conversation
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: 389ds#6415 Author: William Brown <william@blackhats.net.au> Review by: ???
droideck
approved these changes
Nov 22, 2024
droideck
left a comment
droideck
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Builds for Fedora and CentOS 10 work!
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Firstyear
added a commit
that referenced
this pull request
Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining) Fix Description: Correct configure.ac to request linking to icu-uc fixes: #6415 Author: William Brown <william@blackhats.net.au> Review by: @droideck
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining)
Fix Description: Correct configure.ac to request linking to icu-uc
fixes: #6415
Author: William Brown william@blackhats.net.au
Review by: ???