Skip to content

Issue 6415 - BUG - Incorrect icu linking #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

Firstyear
Copy link
Contributor

Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown william@blackhats.net.au

Review by: ???

Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: 389ds#6415

Author: William Brown <william@blackhats.net.au>

Review by: ???
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Builds for Fedora and CentOS 10 work!

@Firstyear Firstyear merged commit 5813c69 into 389ds:main Nov 29, 2024
194 of 197 checks passed
@Firstyear Firstyear deleted the 6415-icu branch November 29, 2024 02:51
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
Firstyear added a commit that referenced this pull request Nov 29, 2024
Bug Description: ICU has been updated to version 76.x - the .pc file of icu-18n for example no
longer includes -licuuc, which was so far the most common reason for buildfailures (as icu-uc is
not linked automatically, resulting in underlining)

Fix Description: Correct configure.ac to request linking to icu-uc

fixes: #6415

Author: William Brown <william@blackhats.net.au>

Review by: @droideck
@Firstyear
Copy link
Contributor Author

   8330cbc6f..e56ce1187  389-ds-base-3.0 -> 389-ds-base-3.0
   979fb5db7..ff9b90991  389-ds-base-2.5 -> 389-ds-base-2.5
   1643e9868..2b040a9c1  389-ds-base-2.4 -> 389-ds-base-2.4
   bb9ca40d1..0fe972fe2  389-ds-base-2.3 -> 389-ds-base-2.3
   8afb46f71..9b5efd9fa  389-ds-base-2.2 -> 389-ds-base-2.2
   2b541c64b..b03d88e6e  389-ds-base-2.1 -> 389-ds-base-2.1
   4b34443ce..a3a738781  389-ds-base-2.0 -> 389-ds-base-2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

properly link to icu-uc
2 participants