Issue 6420 - Update dsidm user get_dn test after BZ 1893667 fix #6421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I don't think we should link BZ here.
And it'll be better to link the upstream issue where the fix is - #5373
And the BZ can be linked there (I'll do it).
So please, fix the commit message (remove BZ number and add the above upstream issue link)
The rest, LGTM!
Description: user get_dn test was marked as expected fail, updating it to working status. Relates: 389ds#5373 Author: Lenka Doudova Reviewed by: ???
|
Thanks for review, commit message changed as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: user get_dn test was marked as expected fail due to BZ issue 1893667. Since the issue is fixed, the test is being updated to working status.
Relates: #6420
Author: Lenka Doudova
Reviewed by: ???