Skip to content

Issue 6422 - test_db_home_dir_online_backup CI test break other tests#6423

Merged
progier389 merged 1 commit into
389ds:mainfrom
progier389:i6386-2
Nov 29, 2024
Merged

Issue 6422 - test_db_home_dir_online_backup CI test break other tests#6423
progier389 merged 1 commit into
389ds:mainfrom
progier389:i6386-2

Conversation

@progier389

@progier389 progier389 commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

test_db_home_dir_online_backup CI test change the dbhome to a directory that
is removed at the test completion but the dbhome is not restored.
The solution is to use a python context manager to change and restore the dse.ldif

Issue: #6422

Reviewed by: @tbordaz , @droideck (Thanks!)

@droideck droideck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tbordaz tbordaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@progier389 progier389 merged commit 7aabfbd into 389ds:main Nov 29, 2024
@progier389 progier389 deleted the i6386-2 branch May 20, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants