Issue 5798 - Fix dsconf config multi-valued attr operations - #6426
Merged
Conversation
Description: Fix add operation to properly handle multi-valued attributes so they persist after server restart. Add support for multiple values at once via dsconf config. Handle delete operation in a more flexible way. Refactor attribute handling code for better error handling and consistency. Fixes: 389ds#5798 Reviewed by: ?
Contributor
|
Looks good, but we should perhaps add some ci test ... |
droideck
added a commit
that referenced
this pull request
Dec 5, 2024
Description: Fix add operation to properly handle multi-valued attributes so they persist after server restart. Add support for multiple values at once via dsconf config. Handle delete operation in a more flexible way. Refactor attribute handling code for better error handling and consistency. *Add CI test suite Fixes: #5798 Reviewed by: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Dec 5, 2024
Description: Fix add operation to properly handle multi-valued attributes so they persist after server restart. Add support for multiple values at once via dsconf config. Handle delete operation in a more flexible way. Refactor attribute handling code for better error handling and consistency. *Add CI test suite Fixes: #5798 Reviewed by: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Dec 5, 2024
Description: Fix add operation to properly handle multi-valued attributes so they persist after server restart. Add support for multiple values at once via dsconf config. Handle delete operation in a more flexible way. Refactor attribute handling code for better error handling and consistency. *Add CI test suite Fixes: #5798 Reviewed by: @progier389 (Thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix add operation to properly handle multi-valued attributes so they persist after server restart.
Add support for multiple values at once via dsconf config. Handle delete operation in a more flexible way.
Refactor attribute handling code for better error handling and consistency.
Fixes: #5798
Reviewed by: ?