Issue 6446 - on replica consumer, account policy plugin fails to mana… #6448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| accp.set('stateattrname', 'lastLoginTime') | ||
| except ldap.LDAPError as e: | ||
| log.error('Failed to enable Global Account Policy Plugin and Password policy attributes') | ||
| raise e |
There was a problem hiding this comment.
Very minor, but I don't think we need these try/excepts - just let it raise the error when it happens. Same for other code below.
mreynolds389
approved these changes
Dec 12, 2024
…ge the last login history Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: 389ds#6446 Reviewed by: Mark Reynolds (Thanks!)
tbordaz
added a commit
that referenced
this pull request
Dec 12, 2024
…ge the last login history (#6448) Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: #6446 Reviewed by: Mark Reynolds (Thanks!)
tbordaz
added a commit
that referenced
this pull request
Dec 12, 2024
…ge the last login history (#6448) Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: #6446 Reviewed by: Mark Reynolds (Thanks!)
tbordaz
added a commit
that referenced
this pull request
Dec 12, 2024
…ge the last login history (#6448) Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: #6446 Reviewed by: Mark Reynolds (Thanks!)
tbordaz
added a commit
that referenced
this pull request
Dec 12, 2024
…ge the last login history (#6448) Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: #6446 Reviewed by: Mark Reynolds (Thanks!)
tbordaz
added a commit
that referenced
this pull request
Dec 12, 2024
…ge the last login history (#6448) Bug description: An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS on a RO consumer. Else the server does not select the backend and returns LDAP_REFERRAL to the internal operation. In acct_update_login_history the flag is missing. Fix description: Use the same flags in acct_update_login_history as it is used in acct_record_login fixes: #6446 Reviewed by: Mark Reynolds (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge the last login history
Bug description:
An internal update needs the flag SLAPI_OP_FLAG_BYPASS_REFERRALS
on a RO consumer. Else the server does not select the backend
and returns LDAP_REFERRAL to the internal operation.
In acct_update_login_history the flag is missing.
Fix description:
Use the same flags in acct_update_login_history as it is
used in acct_record_login
fixes: #6446
Reviewed by: