Issue 6459 - crash on 3.0/3.1 branch

[progier389]

vlv_rebuild_scope_filter code looks fishy:
it aborts the dblayer_read_txn_begin txn with dblayer_txn_abort instead of dblayer_read_txn_abort
(Meaning that it tries to release the backend serial lock without having locked it.)
This generates assertion failure on some distributions.

Issue: 6459

Reviewed by: @tbordaz (Thanks!)

[tbordaz]

LGTM
By the way I was suprise to not being able to reproduce it locally

[progier389]

LGTM By the way I was suprise to not being able to reproduce it locally

Assertion are not verified in if -DDEBUG flag is not set
But when done test I routinely use debug build on Fedora and never hit it, so I guess that something else hid it.

[stanislavlevin]

With this patch I don't see the crash any more.

[stanislavlevin]

LGTM By the way I was suprise to not being able to reproduce it locally

Assertion are not verified in if -DDEBUG flag is not set But when done test I routinely use debug build on Fedora and never hit it, so I guess that something else hid it.

This assertion is controlled by --{disable,enable}-debug configure option of nspr project. For Fedora it's --disable-debug (https://src.fedoraproject.org/rpms/nss/blob/rawhide/f/nss.spec#_331).