Skip to content

Issue 6478 - fix compilation warning related to deferred memberof delay #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Jan 7, 2025

Trivial compilation warning fix.

Issue: #6478

Reviewed by: @tbordaz

@progier389
Copy link
Contributor Author

I know that this code will be rewritten soon (when replacing the sleep by condvar) but
lets get rid of the warning in the mean time.
The truth is that I am a bit fed up of wasting time looking closely at the log again and again because I see an unexpected warning during the compilation! 😉

@progier389 progier389 linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note, it may contain a mix of tabs and spaces in the indent

@progier389
Copy link
Contributor Author

it may contain a mix of tabs and spaces in the indent

Yeah, it is hard to distinguish tab from space in the review but grep does no show any tabs in the modified files
so we are good.
Thanks for the caveat anyway !

@progier389 progier389 merged commit ba09249 into 389ds:main Jan 7, 2025
9 checks passed
@progier389 progier389 deleted the i6478 branch May 20, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warning due to deferred memberof delay
2 participants