Issue 6478 - fix compilation warning related to deferred memberof delay#6479
Merged
progier389 merged 1 commit into389ds:mainfrom Jan 7, 2025
Merged
Issue 6478 - fix compilation warning related to deferred memberof delay#6479progier389 merged 1 commit into389ds:mainfrom
progier389 merged 1 commit into389ds:mainfrom
Conversation
Contributor
Author
|
I know that this code will be rewritten soon (when replacing the sleep by condvar) but |
tbordaz
approved these changes
Jan 7, 2025
Contributor
tbordaz
left a comment
tbordaz
left a comment
There was a problem hiding this comment.
LGTM
Note, it may contain a mix of tabs and spaces in the indent
Contributor
Author
Yeah, it is hard to distinguish tab from space in the review but grep does no show any tabs in the modified files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial compilation warning fix.
Issue: #6478
Reviewed by: @tbordaz