Skip to content

Issue 6490 - Add a new macro function and print rounds on startup #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

droideck
Copy link
Member

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: ?

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: 389ds#6490

Reviewed by: ?
Copy link
Contributor

@mreynolds389 mreynolds389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but not a rust guy. But this looks simple enough so I'm acking!

@droideck droideck merged commit 2bb6362 into 389ds:main Jan 14, 2025
197 of 199 checks passed
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this pull request Jan 14, 2025
)

Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: #6490

Reviewed by: @mreynolds389 (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust rust pwchan error severity level
2 participants