-
Notifications
You must be signed in to change notification settings - Fork 103
Issue 6490 - Add a new macro function and print rounds on startup #6496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: 389ds#6490 Reviewed by: ?
mreynolds389
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, but not a rust guy. But this looks simple enough so I'm acking!
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup. Fixes: #6490 Reviewed by: @mreynolds389 (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.
Fixes: #6490
Reviewed by: ?