Issue 6497 - lib389 - Configure replication for multiple suffixes #6498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks incomplete: lots of replication test are now failing. |
droideck
force-pushed
the
repl-multi-suffixes
branch
2 times, most recently
from
5eccbf5 to
f3f3261
Compare
Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: 389ds#6497 Reviewed: ?
droideck
force-pushed
the
repl-multi-suffixes
branch
from
f3f3261 to
425e0ab
Compare
|
Thanks! Yeah, I first fixed the main functionality and posted it for a preliminary review (and went to sleep). |
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Jan 14, 2025
) Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes. Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix. Enable DSLdapObject.present method to compare values as a normalized DNs if they are DNs. Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers. Fix tests that are related to repl service accounts. Fixes: #6497 Reviewed: @progier389 (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: When trying to set up replication across multiple suffixes - particularly if one of those suffixes is a subsuffix - lib389 fails to properly configure the replication agreements, service accounts, and required groups. The references to the replication_managers group and service account naming do not correctly account for non-default additional suffixes.
Fix Description: Ensure replication DNs and credentials are correctly tied to each suffix.
Add a test (test_multi_subsuffix_replication) to verify multi-suffix replication across four suppliers.
Fixes: #6497
Reviewed: ?