Issue 6507 - changelog modifiers operation not displayed in dbscan #6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreynolds389
approved these changes
Jan 17, 2025
tbordaz
approved these changes
Jan 17, 2025
| @@ -516,6 +521,10 @@ _cl5ReadMod(char **buff) | |||
| val_count = ntohl(val_count); | |||
| pos += sizeof(uint32_t); | |||
|
|
|||
| op &= LDAP_MOD_OP; | |||
| if (print_op && op < PR_ARRAY_SIZE(ops)) { | |||
There was a problem hiding this comment.
It should be the case but just for safety you may check that op>0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when dbscan dumps the changelog, it does not display modify operation modifier sub operation
(i.e: add/delete/replace) on the specified attribute
Solution:
Use a format similar to the ldif one:
but only when dumpoing a modify operation : add and modrdn still use the
format
Issue: #6507
Reviewd by: @mreynolds389, @tbordaz (Thanks!)