Issue 6516 - Allow to configure the password scheme not updated on bind #6517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progier389
reviewed
Jan 20, 2025
| @@ -132,6 +146,159 @@ def test_password_modify_non_utf8(topology_st, pbkdf2_sha512_scheme): | |||
|
|
|||
| log.info('test_password_modify_non_utf8: PASSED') | |||
|
|
|||
| def test_pwd_scheme_not_upgraded_on_bind(topology_st, crypt_scheme, request): | |||
There was a problem hiding this comment.
FYI: since test_pwd_scheme_not_upgraded_on_bind and test_pwd_scheme_crypt_upgraded_on_bind are very similar, I think you should rather have a single parametrized test
each parameter values being a tuple (no_upgrade_hash_value, expected_hash_after_bind)
ldap/servers/slapd/pw.c
Outdated
| /* values are comma separated list. Add heading/ending commas | ||
| * to retrieve the exact current hash in that list | ||
| */ | ||
| no_upgrade_hashes = slapi_ch_smprintf(",%s,", slapdFrontendConfig->scheme_list_no_upgrade_hash); |
There was a problem hiding this comment.
Nice trick. FYI you could also keep the configuration parameter as is and use strtok_r to parse it:
char *saveptr = NULL;
no_upgrade_hashes = slapi_ch_strdup(slapdFrontendConfig->scheme_list_no_upgrade_hash);
for (char *hash = strtok_r(no_upgrade_hashes, ", \t\n", &saveptr);
hash;
hash = strtok_r(NULL, ", \t\n", &saveptr)) {
if strcasecmp(hash, curpwsp->pws_name) == )) {
ignore_upgrade = 1;
break;
}
}
slapi_ch_free_string(&no_upgrade_hashes);
Bug description: The configuration option 'nsslapd-enable-upgrade-hash: on' allows to update, during a user bind, the password storage hash of the user password. The update sets the password storage hash to the one defined in the password policy (passwordStorageScheme) If the current user password hash is 'CRYPT' or 'CLEAR' then the password storage hash is not updated. This is hardcoded. Fix description: Introduce a new configuration parameter that list the hashes that are *not* upgraded during a bind. 'nsslapd-scheme-list-no-upgrade-hash' fixes: 389ds#6516 Reviewed by: Pierre Rogier
tbordaz
added a commit
that referenced
this pull request
Jan 22, 2025
…nd (#6517) Bug description: The configuration option 'nsslapd-enable-upgrade-hash: on' allows to update, during a user bind, the password storage hash of the user password. The update sets the password storage hash to the one defined in the password policy (passwordStorageScheme) If the current user password hash is 'CRYPT' or 'CLEAR' then the password storage hash is not updated. This is hardcoded. Fix description: Introduce a new configuration parameter that list the hashes that are *not* upgraded during a bind. 'nsslapd-scheme-list-no-upgrade-hash' fixes: #6516 Reviewed by: Pierre Rogier
tbordaz
added a commit
that referenced
this pull request
Jan 22, 2025
…nd (#6517) Bug description: The configuration option 'nsslapd-enable-upgrade-hash: on' allows to update, during a user bind, the password storage hash of the user password. The update sets the password storage hash to the one defined in the password policy (passwordStorageScheme) If the current user password hash is 'CRYPT' or 'CLEAR' then the password storage hash is not updated. This is hardcoded. Fix description: Introduce a new configuration parameter that list the hashes that are *not* upgraded during a bind. 'nsslapd-scheme-list-no-upgrade-hash' fixes: #6516 Reviewed by: Pierre Rogier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
The configuration option 'nsslapd-enable-upgrade-hash: on' allows
to update, during a user bind, the password storage hash of the
user password.
The update sets the password storage hash to the one defined in the
password policy (passwordStorageScheme)
Fix description:
Introduce a new configuration parameter that list the hashes
that are not upgraded during a bind.
'nsslapd-scheme-list-no-upgrade-hash'
fixes: #6516
Reviewed by: