Repository navigation
Issue 6555 - Potential crash when deleting a replicated backend - #6559
Merged
Merged
Conversation
droideck
approved these changes
Jan 30, 2025
| void replica_set_updatedn(Replica *r, const Slapi_ValueSet *vs, int mod_op); | ||
| void replica_set_groupdn(Replica *r, const Slapi_ValueSet *vs, int mod_op); | ||
| char *replica_get_generation(const Replica *r); | ||
| bool replica_check_validity(Replica *replica); |
Member
There was a problem hiding this comment.
It feels a bit inconsistent to use bool while every other line in the file uses PRBool... But I understand we might get rid of PRBool at some point.
I don't have a hard opinion here, but generally, I'd prefer consistency in this case (my 5 cents). :)
Contributor
Author
There was a problem hiding this comment.
FYI: I discussed that one with Mark in another review, and finally we decided to use stdbool in new code.
I agree it is inconsistent, until we do a global cleanup phase (but frankly I am afraid that there are dependencies toward the plugin API and we will never be able to complete that move )
progier389
added a commit
to progier389/389-ds-base
that referenced
this pull request
Feb 5, 2025
…nd (389ds#6559)" This reverts commit f5e5b59. because with this commit server may hang at shutdown
progier389
added a commit
to progier389/389-ds-base
that referenced
this pull request
Feb 5, 2025
…nd (389ds#6559)" This reverts commit f5e5b59.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: connection cleanup may try to access a freed replica
Solution: Ensure that the replica is still existing before using its pointer
Issue: #6555
Reviewed by: @tbordaz, @droideck (Thanks!)