Repository navigation
Issue 6596 - BUG - Compilation Regresion - #6597
Merged
Merged
Conversation
Contributor
Author
|
Requires backport to 3.0 and 2.5 |
droideck
approved these changes
Feb 7, 2025
droideck
left a comment
droideck
left a comment
Member
There was a problem hiding this comment.
LGTM!
Should we also add the same for SLAPI_OPERATION_DELETE and SLAPI_OPERATION_MODDN cases? Even though it's not required but for consistency it'll be nice
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: 389ds#6596 Author: William Brown <william@blackhats.net.au> Review by: ???
Firstyear
force-pushed
the
20250207-6596-compilation-issue
branch
from
February 7, 2025 04:21
9b5eac0 to
d0f1cc0
Compare
Contributor
Author
|
Easy, done! |
Firstyear
added a commit
that referenced
this pull request
Feb 7, 2025
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: #6596 Author: William Brown <william@blackhats.net.au> Review by: @droideck Thanks!
Firstyear
added a commit
that referenced
this pull request
Feb 7, 2025
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: #6596 Author: William Brown <william@blackhats.net.au> Review by: @droideck Thanks!
Contributor
Author
|
Firstyear
added a commit
that referenced
this pull request
Feb 4, 2026
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: #6596 Author: William Brown <william@blackhats.net.au> Review by: @droideck Thanks!
Contributor
Author
Seems many moons ago this was forgotten by me to backport to 2.7 |
|
Backport-action backported this pull request in workflow run 35316166970.
|
This was referenced Sep 18, 2026
|
Backport-action backported this pull request in workflow run 35316170284.
|
vashirov
pushed a commit
that referenced
this pull request
Sep 18, 2026
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: #6596 Author: William Brown <william@blackhats.net.au> Review by: @droideck Thanks! (cherry picked from commit 042f7c9)
vashirov
pushed a commit
that referenced
this pull request
Sep 18, 2026
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration. Fix Description: Enclose the switch/case in braces to resolve the compilation issue. fixes: #6596 Author: William Brown <william@blackhats.net.au> Review by: @droideck Thanks! (cherry picked from commit 042f7c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration.
Fix Description: Enclose the switch/case in braces to resolve the compilation issue.
fixes: #6596
Author: William Brown william@blackhats.net.au
Review by: ???