Repository navigation
Issue 6734 - BUG - format strings may not contain backslash - #6749
Merged
Merged
Conversation
vashirov
approved these changes
Apr 15, 2025
vashirov
left a comment
Member
There was a problem hiding this comment.
Build no longer fails on EL9, thanks!
droideck
approved these changes
Apr 15, 2025
droideck
left a comment
Member
There was a problem hiding this comment.
Otherwise, the fix looks good!
Bug Description: Format strings may not contain backslashes in older versions of python 3 Fix Description: pre-format the strings fixes: 389ds#6734 Author: William Brown <william@blackhats.net.au> Review by: @droideck @vashirov (thanks!)
Firstyear
force-pushed
the
20250415-6734-f-strings
branch
from
April 17, 2025 00:19
b7dc727 to
efa847f
Compare
abeisemb
pushed a commit
to abeisemb/389-ds-base
that referenced
this pull request
Apr 17, 2025
Bug Description: Format strings may not contain backslashes in older versions of python 3 Fix Description: pre-format the strings fixes: 389ds#6734 Author: William Brown <william@blackhats.net.au> Review by: @droideck @vashirov (thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description: Format strings may not contain backslashes in older versions of python 3 (3.6/3.9 for example).
Fix Description: pre-format the strings.
fixes: #6734
Author: William Brown william@blackhats.net.au
Review by: ???