Skip to content

Issue 6734 - BUG - format strings may not contain backslash - #6749

Merged
Firstyear merged 1 commit into
389ds:mainfrom
Firstyear:20250415-6734-f-strings
Apr 17, 2025
Merged

Firstyear merged 1 commit into
389ds:mainfrom
Firstyear:20250415-6734-f-strings

Conversation

@Firstyear

Copy link
Copy Markdown
Contributor

Bug Description: Format strings may not contain backslashes in older versions of python 3 (3.6/3.9 for example).

Fix Description: pre-format the strings.

fixes: #6734

Author: William Brown william@blackhats.net.au

Review by: ???

@vashirov vashirov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build no longer fails on EL9, thanks!

@droideck droideck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the fix looks good!

Comment thread src/lib389/lib389/_mapped_object.py Resolved
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: 389ds#6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
@Firstyear
Firstyear force-pushed the 20250415-6734-f-strings branch from b7dc727 to efa847f Compare April 17, 2025 00:19
@Firstyear
Firstyear merged commit 95a3a9d into 389ds:main Apr 17, 2025
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Firstyear added a commit that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: #6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
@Firstyear
Firstyear deleted the 20250415-6734-f-strings branch April 17, 2025 00:45
abeisemb pushed a commit to abeisemb/389-ds-base that referenced this pull request Apr 17, 2025
Bug Description: Format strings may not contain backslashes in
older versions of python 3

Fix Description: pre-format the strings

fixes: 389ds#6734

Author: William Brown <william@blackhats.net.au>

Review by: @droideck @vashirov (thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI - dsidm should have option to list DN's

3 participants