Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2019 supprt #44

Closed
elangelo opened this issue May 3, 2019 · 6 comments

Comments

@elangelo
Copy link

commented May 3, 2019

Any chance we might get this?

@3F

This comment has been minimized.

Copy link
Owner

commented May 3, 2019

Sure. This is still my active project (today, this is still actively integrated with our other projects).
Therefore, I have plans for VS2019 too.

Just no time for fast support.
Anybody can also help to add some (#39) support. I'll definitely review any PR.

Thanks for using and follow the news.

@elangelo

This comment has been minimized.

Copy link
Author

commented May 6, 2019

I've been trying to get this to work on 2019 but i keep getting:
image

If i remember correctly on 2017 you got a yes/no button to still install it. Somehow that no longer works on 2019. I'll keep trying...
If you have any hints in what directions i should be looking that would be greatly appreciated.

@elangelo

This comment has been minimized.

Copy link
Author

commented May 6, 2019

after closing and reopening visual studio my branch actually builds something that works for me. I don't want to create a PR for this because it's clearly not sufficient but maybe you could already have a look?

elangelo@2c04d3f

@3F

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

@elangelo we're using VSIX manifest v1 with the following list of SupportedProducts Elements (VSX Schema) for support all products starting from VS2010+. But this is obsolete way after VS 15.0 (read #36)

As for temp VS2010+solution, you can try to add partial support for 16.0 via the same <VisualStudio Version="16.0"> record:

<VisualStudio Version="15.0">
<Edition>Community</Edition>
<Edition>Enterprise</Edition>
<Edition>Ultimate</Edition>
<Edition>Premium</Edition>
<Edition>Pro</Edition>
<Edition>IntegratedShell</Edition>
</VisualStudio>

Moreover, I can accept PR if it will work in real use with latest RC VS2019. However, full support means usage VSIX v3 :( that of course requires separate distribution for:

VS2010, - v1
VS2012, - v1, (v2 - optional)
VS2013, - v1, (v2 - optional)
VS2015, - v1, (v2 - optional)
VS2017, - v3
VS2019. - v3

I have no priority to this for the coming months, but you also can try to add configuration for build both packages (v1 & v3 manifest)

Anyway, most of changes for this product has been planned for this year, ie. some parts should be extracted into the new projects at all and some parts should be replaced by already existing:

@3F 3F referenced this issue Jun 5, 2019

Merged

Support of the modern 15+ products #45

7 of 7 tasks complete
@3F

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2019

Today, #45 finally initiates support of the modern 15+ products (n. VS2017 is 15, VS2019 is 16).

Modern platform requires more than just update manifest file. I already added AsyncPackages implementation. So, basically we need to resolve some problems and add separate build of the both vsix packages. See the remaining subtasks there.

Welcome everyone to speed up the process, or please wait for my time.

@3F 3F added this to the 0.12.11 milestone Jun 7, 2019

@3F 3F closed this in #45 Jun 28, 2019

@3F

This comment has been minimized.

Copy link
Owner

commented Jun 28, 2019

We're fully ready for VS2019 and now completely integrated with *VS2017.

  • For VS2017 will be also available old SDK10 package implementation like today's 0.12.10.10901. But SDK15 is recommended.

Other:

  • Starting from VS2019 you need use only SDK15 packages.
  • VS2010, VS2012, VS2013, VS2015: SDK10
  • CI /Build Servers, msbuild tools: SDK10 or SDK15
  • Devenv Command Line version: SDK10
  • API: SDK10 or SDK15

All binaries will be available from our GitHub Releases Page. (I've plan to migrate from sf for new publishing)

Everyone, please also test the last CI build before public release!

Known problems here: #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.