Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: change KtNavbarTheme to KtTheme #63 #64

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@ostoc
Copy link
Member

ostoc commented Feb 28, 2019

The API changes will change when next release, you don't need to specify the borderColor anymore.

Prvider name changed from KtNavbarTheme to KtTheme

Default Theme Provider

provide() {
	return {
		KtTheme: {
			navbarBackgroundColor: '#122C56',
			navbarTextColor: 'rgba(255,255,255,.54)',
			navbarTextActiveColor: 'rgba(255,255,255, 1)',
			logoUrl: LogoSvg,
			logoHeight: '40px',
		},
	}
},
feature: change KtNavbarTheme to KtTheme #63
- Using KtTheme for Navbar and Button
- Provide APIs changes

@ostoc ostoc requested review from FlorianWendelborn and justinline Feb 28, 2019

@ostoc ostoc merged commit 9f7675b into master Mar 1, 2019

@FlorianWendelborn
Copy link
Member

FlorianWendelborn left a comment

LGTM besides the two things I mentioned.

@@ -82,29 +82,31 @@ quickLinksData: {

`KtNavbar` injects the theme provided by the parent or globally.

When `KtNavbarTheme` object is provided, it will replace the default theme.
When `KtTheme` object is not provided, it will replace the default theme.

This comment has been minimized.

@FlorianWendelborn

FlorianWendelborn Mar 2, 2019

Member

I don’t understand this sentence since you added the not.

This comment has been minimized.

@ostoc

ostoc Mar 4, 2019

Author Member

when there is no KtTheme object provided. Kotti will use default theme (the dark blue one)

}),
KtTheme: {
default: {
navbarBackgroundColor: '#122C56',

This comment has been minimized.

@FlorianWendelborn

FlorianWendelborn Mar 2, 2019

Member

I’d suggest moving this (partially repeated, and logically belonging together) piece of code to a utility file (e.g. default-theme.json). You can just import that everywhere where you need the default theme then. 🙂

This comment has been minimized.

@ostoc

ostoc Mar 4, 2019

Author Member

yep, a good idea. can do when we have more theme need to be configured.

@ostoc ostoc deleted the KtNavbar-boarder-color branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.