Support the elliptical arc command for SVGMobject #1598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support the elliptical arc command for SVGMobject. Now all the commands of svg path can be implemented.
Proposed changes
This is reached through approximating elliptical arcs with quadratic bezier curves, which is almost the same way to form a circular arc in
Arc
class. The key is to figure out the center of the ellipse, requiring us to solve simultaneous equations. I've built a functionadd_elliptical_arc_to(self, rx, ry, x_axis_rotation, large_arc_flag, sweep_flag, point)
, inside which a bunch of functions were defined just to do those calculations. I guess it might be better to transfer them into the fileutils\space_ops.py
, but I daren't make too much changes across files in my first pull request.Detailed annotations are left in the code. I deduced all those stuff by hand today .(:з」∠).
Test
Code:
Result: