Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor command handling in svg_mobject.py #1662

Merged
merged 2 commits into from
Oct 24, 2021
Merged

Refactor command handling in svg_mobject.py #1662

merged 2 commits into from
Oct 24, 2021

Conversation

YishiMichael
Copy link
Contributor

Motivation

The code modified in #1598 , where I added support for A command, is a little bit messy, so I go on to refactor some code in svg_mobject.py.

@TonyCrane TonyCrane requested a review from 3b1b October 24, 2021 14:36
@YishiMichael
Copy link
Contributor Author

Additionally, I've updated the balance_braces method in tex_mobject.py file so that now it can handle inputs like }{.

@3b1b 3b1b merged commit f1c5064 into 3b1b:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyCrane TonyCrane TonyCrane approved these changes

@3b1b 3b1b Awaiting requested review from 3b1b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YishiMichael @TonyCrane @3b1b