Parse style from <style> tag and Add support to <line> tag #1719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1717 (comment)
I solved this issue. Use tinycss2 to parse style (including
<style>
tag andstyle
attributes in other tags), and use cssselect2 to choose which tag to apply to based on selector.And in order to make cssselect2 handle selectors correctly, I replaced
xml.dom.minidom
withxml.etree
for parsing SVG file, which also has more features.At the same time, I also implemented the processing of the
<line>
tag by the way.Proposed changes
manimlib/mobject/svg/svg_mobject.py
: improve style parsing and implement the<line>
tagsetup.cfg
&requirements.txt
: add dependency ofcssselect2
(tinycss2
will be installed along with it)Test
Code:
Result:
Code:
Result: