Reorganize inheriting order and refactor SVGMobject #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
TonyCrane
requested changes
Feb 15, 2022
TonyCrane
requested changes
Feb 15, 2022
TonyCrane
approved these changes
Feb 15, 2022
|
Nice, this feels like a much more reasonable inheritance structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix some potential bugs left in #1731.
Proposed changes
manimlib/mobject/svg/svg_mobject.py: Addsvg_defaultdictionary to allow users to specifically fill in style attributes to elements whose style is not specified in svg scope (and the functionality ofinit_colorsis therefore preserved); usexml.dom.ElementTreepackage to parse style attributes in the outer svg tag; useSVG_HASH_TO_MOB_MAPto cache svg mobjectsmanimlib/mobject/svg/drawings.py: Remove unnecessaryinit_colorsoverridemanimlib/mobject/svg/text_mobject.py: Remove unnecessaryset_fillprocessmanimlib/mobject/svg/mtex_mobject.py: Reorganize inheriting structure (MTexinherits fromSVGMobject)manimlib/mobject/svg/tex_mobject.py: Reorganize inheriting structure (SingleStringTexinherits fromSVGMobject)manimlib/utils/tex_file_writing.py: Avoid the message from being too longmanimlib/utils/iterables.py: Addhash_objfunction to hash objects that may contain dictionaries