Fix bug when handling multi-line tex#1785
Merged
3b1b merged 3 commits into3b1b:masterfrom Apr 11, 2022
YishiMichael:master
Merged
Fix bug when handling multi-line tex#17853b1b merged 3 commits into3b1b:masterfrom YishiMichael:master
3b1b merged 3 commits into3b1b:masterfrom
YishiMichael:master
Conversation
TonyCrane
approved these changes
Apr 10, 2022
YishiMichael
added a commit
to YishiMichael/ManimGL-MathJax
that referenced
this pull request
Apr 11, 2022
YishiMichael
added a commit
to manim-kindergarten/ManimGL-MathJax
that referenced
this pull request
Apr 12, 2022
Align with 3b1b/manim#1785; Refactor AM
TonyCrane
added a commit
that referenced
this pull request
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug when dealing with multi-line tex. Just fixed.
Proposed changes
manimlib/animation/creation.py: use attribute instead of calling a methodmanimlib/animation/transform_matching_parts.py: clean up logicmanimlib/mobject/svg/labelled_string.py: fix bug; addregexparameter forget_parts_by_texmethod; removeindices_of_partandindices_lists_of_partsmethodsmanimlib/mobject/svg/mtex_mobject.py: some small refactorsmanimlib/mobject/svg/text_mobject.py: some small refactors