Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when handling multi-line tex #1785

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix bug when handling multi-line tex #1785

merged 3 commits into from
Apr 11, 2022

Conversation

YishiMichael
Copy link
Contributor

@YishiMichael YishiMichael commented Apr 10, 2022

Motivation

There's a bug when dealing with multi-line tex. Just fixed.

Proposed changes

  • M manimlib/animation/creation.py: use attribute instead of calling a method
  • M manimlib/animation/transform_matching_parts.py: clean up logic
  • M manimlib/mobject/svg/labelled_string.py: fix bug; add regex parameter for get_parts_by_tex method; remove indices_of_part and indices_lists_of_parts methods
  • M manimlib/mobject/svg/mtex_mobject.py: some small refactors
  • M manimlib/mobject/svg/text_mobject.py: some small refactors

@TonyCrane TonyCrane self-requested a review April 10, 2022 03:43
@TonyCrane TonyCrane requested a review from 3b1b April 10, 2022 03:46
@YishiMichael YishiMichael marked this pull request as draft April 11, 2022 03:54
@YishiMichael YishiMichael marked this pull request as ready for review April 11, 2022 15:46
YishiMichael added a commit to YishiMichael/ManimGL-MathJax that referenced this pull request Apr 11, 2022
@3b1b 3b1b merged commit 773520b into 3b1b:master Apr 11, 2022
YishiMichael added a commit to manim-kindergarten/ManimGL-MathJax that referenced this pull request Apr 12, 2022
TonyCrane added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants