Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Stats Area with Gameplay Info #23

Closed
1 of 4 tasks
3daddict opened this issue Oct 5, 2018 · 6 comments
Closed
1 of 4 tasks

Create a Stats Area with Gameplay Info #23

3daddict opened this issue Oct 5, 2018 · 6 comments
Labels
👩‍💻assigned This Issue has been assigned and is in progress enhancement New feature or request Hacktoberfest help wanted Extra attention is needed

Comments

@3daddict
Copy link
Owner

3daddict commented Oct 5, 2018

Before you begin:

Confirm that you're working on this issue so I can add assigned label.

Use dev branch as a base for your PR.

Read the contribution guide for info how to setup project, run tests and use development version of packages.

Create a Stats Area that will eventually go in the side nav once that issue completed and is merged.
Stats Container

  • Games Played - Show how many times the game is played
  • Add a Start new Game button and function to re-populate the DOM with cards
  • Number of Attempts - number of times the user has clicked on cards
  • Accuracy (how many times they got it right / number of total clicks for the current game
@3daddict 3daddict added enhancement New feature or request help wanted Extra attention is needed Hacktoberfest labels Oct 5, 2018
@BennyCarlsson
Copy link
Contributor

Would like to add Number of Attempts

@3daddict 3daddict added the 👩‍💻assigned This Issue has been assigned and is in progress label Oct 5, 2018
@3daddict
Copy link
Owner Author

3daddict commented Oct 5, 2018

Would like to add Number of Attempts

You got it!

@3daddict 3daddict removed the 👩‍💻assigned This Issue has been assigned and is in progress label Oct 5, 2018
@klauskpm
Copy link
Contributor

klauskpm commented Oct 5, 2018

Hey @3daddict . I'd like to take the other 3 tasks.

@3daddict 3daddict added the 👩‍💻assigned This Issue has been assigned and is in progress label Oct 5, 2018
@3daddict
Copy link
Owner Author

3daddict commented Oct 5, 2018

Hey @3daddict . I'd like to take the other 3 tasks.

You got it!

@klauskpm
Copy link
Contributor

klauskpm commented Oct 5, 2018

Hey @3daddict. I found a problem with the attempts logic.

If we count each click as an attempt, then if I click on 2 cards and get it right, my accuracy will be 50%. There are two approaches I can take:

  • Make attempts only count when there is a second click; (I'd recommend that)
  • Calculate accuracy based on half of attempts;

@3daddict
Copy link
Owner Author

3daddict commented Oct 5, 2018

  • Make attempts only count when there is a second click; (I'd recommend that)

@klauskpm great feedback, please go with your recommended approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻assigned This Issue has been assigned and is in progress enhancement New feature or request Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants