Errors in Moodle 2.5.1 and Fixes for Moodle 2.6

[michael-milette]

Hi 3i,

There are a number of warnings that come up when you use the Training Plan plugin on Moodle 2.5.1 and 2.6. I have created a pull request which addresses the issues and makes the plugin Moodle 2.6 compatible. Please see #3

Here are just a few of the many notices, warnings and errors generated by Moodle and PHP. Unfortunately I didn't track the rest of the issues that have been addressed for Moodle 2.6 compatibility.

==> In Moodle 2.5.1

When displaying the "Add Learning Plan" page, the fix addresses the following Moodle error messages:

Strict Standards: Declaration of learningplan_form::validation() should be compatible with that of moodleform::validation() in /moodle/blocks/learning_plan/learning_plan_form.php on line 29.

Strict Standards: Declaration of training_form::validation() should be compatible with that of moodleform::validation() in /moodle/blocks/learning_plan/learning_plan_form.php on line 123.

==> In Moodle 2.6.x.

The following warnings occur when on the plugin’s Search page:

• Warning: Missing argument 1 for search::display_list(), called in /www/moodle/blocks/learning_plan/view.php on line 241 and defined in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 479
• Warning: Missing argument 2 for search::display_list(), called in /www/moodle/blocks/learning_plan/view.php on line 241 and defined in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 479
• Warning: Missing argument 3 for search::display_list(), called in /www/moodle/blocks/learning_plan/view.php on line 241 and defined in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 479
• Notice: Undefined variable: status in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 491
• Notice: Undefined variable: lp_id in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 507
• Notice: Undefined variable: t_id in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 507
• Notice: Undefined variable: status in /www/moodle/blocks/learning_plan/learning_plan_form.php on line 507

In addition, upon performing a search, the following errors are displayed:
Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result

• line 41 of /blocks/learning_plan/ajax_bridge.php: call to moodleform->moodleform()

Doing a search with the Status field set to “All Status”, you also get the following errors:

• Notice: Undefined variable: status_value in /www/moodle/blocks/learning_plan/lib.php on line 75

I would appreciate it if you would be so kind as to give me an idea of when these fixes might be integrated into the official distrubution on Moodle.org.

Best regards,

Michael Milette