Refresh Makefile.FreeBSD to current versions

[diizzyy]

Change default compilter to clang (cc)
Append CFLAGS and LDFLAGS instead of hardcoding
Remove hardcoded optimization and no-strict-aliasing
Fix typo

Signed-off-by: Daniel Engberg daniel.engberg.lists@pyret.net

[z3APA3A]

-fno-strict-aliasing is required, it disables strict aliasing optimization. Current code is not compatible with strict aliasing, and at least gcc in latest versions enables strict aliasing by default and has known problems with aliasing detection, it leads to 3proxy crashes if compiled with some gcc versions without this flag

[diizzyy]

Thanks for the review and useful information!
How do you want to proceed? Tier 1 on 12.X uses clang, on 13.X the only exception is MIPS which isn't built by default. Add a comment if people want to use GCC? FreeBSD 11 is near end of life (Sept 30 2021) which a few more platforms still uses GCC on.

[z3APA3A]

clang supports -fno-strict-aliasing either. And AFAIK it's really required here, without -fno-strict-aliasing result can be unpredictable, see e.g. https://stackoverflow.com/questions/55264205/clang-strict-aliasing-optimizations-vs-unreachable-code-violating-strict-aliasin

[diizzyy]

I see, I'm asking because that port hasn't used in almost a year now
freebsd/freebsd-ports@4db96ef#diff-d0ae2cb73f773c40c87b7d3749bf0efa9732299458bf933d6ea247e43ef86ac1

[z3APA3A]

I have applied some of proposed changes, see 34c4162

[diizzyy]

Thanks!