Skip to content

Removing part of my last request #6

merged 1 commit into from Mar 13, 2013

2 participants


For some reason, when I first made my changes to fix bytesRemaining I needed line 181 to have bytesRemaining-- unless it'd fall behind. However, this might have been due to a bad version of node, or something else as now when running it that line must be taken out in order to maintain an accurate bytesRemaining count. Sorry about the confusion.


@crash2burn hey no sweat, i'm gonna see if I can somehow expose this property for testing. As it's rather critical to have it working properly.

On the related note, I have seen a lot of high quality pull requests from you, would you like to have commit access to the repo?

@3rd-Eden 3rd-Eden merged commit 3764a0e into 3rd-Eden:master Mar 13, 2013

1 check passed

Details default The Travis build passed

The only decent solution I could come up with is to do function generation:

This allows us to inject code to the parse function based on env variables for example. This way we could add an emit call at the end of the loop that emits the bytes remaining, cursor position etc without adding performance overhead for the normal usage. I don't know if you have any better solutions then this idea, i'm open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.