Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated invalid test for binary files #33

Merged
merged 1 commit into from Mar 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

damondanieli commented Mar 23, 2012

The assertion was testing answer === answer instead
of checking the original message.

Binary files are getting changed between set and get. The
assertion in the tests was not checking this.

@damondanieli damondanieli Updated invalid test for binary files
The assertion was testing answer === answer instead
of checking the original message.
d17466a
Owner

3rd-Eden commented Mar 26, 2012

Ouch, thanks for noticing

@3rd-Eden 3rd-Eden added a commit that referenced this pull request Mar 26, 2012

@3rd-Eden 3rd-Eden Merge pull request #33 from appuri/binary-files-differ
Updated invalid test for binary files
f2faf12

@3rd-Eden 3rd-Eden merged commit f2faf12 into 3rd-Eden:master Mar 26, 2012

Owner

3rd-Eden commented Mar 26, 2012

But I don't have a clue yet why this change occurs for binary files.

On Friday, March 23, 2012 at 7:48 PM, Damon Danieli wrote:

The assertion was testing answer === answer instead
of checking the original message.

Binary files are getting changed between set and get. The
assertion in the tests was not checking this.

You can merge this Pull Request by running:

git pull https://github.com/appuri/node-memcached binary-files-differ

Or you can view, comment on it, or merge it online at:

3rd-Eden#33

-- Commit Summary --

  • Updated invalid test for binary files

-- File Changes --

M tests/memcached-get-set.test.js (2)

-- Patch Links --

https://github.com/3rd-Eden/node-memcached/pull/33.patch
https://github.com/3rd-Eden/node-memcached/pull/33.diff


Reply to this email directly or view it on GitHub:
3rd-Eden#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment