Added error messages to replace the false argument in 2 query callbacks on server error #52

Merged
merged 2 commits into from Jun 21, 2012

2 participants

@ronkorving
Collaborator

As we discussed on IRC, we want all errors to yield a truthy error argument in the callback. Arguably, these should change to Error instances, but for the two I added I stuck with the current way of yielding errors (simple strings).

@3rd-Eden
Owner

LGTM,

I think if we went with full new Error instances we would have to do a major version bump as backwards compatibility would break.

Anyways thanks for the pull request, i'll publish a new version a min

@3rd-Eden 3rd-Eden merged commit 75452b4 into 3rd-Eden:master Jun 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment