Fix for issue with values starting with OK, VALUE etc. #71

Merged
merged 1 commit into from Nov 21, 2012

Conversation

Projects
None yet
2 participants
@sebastianseilund
Contributor

sebastianseilund commented Nov 19, 2012

Hi Arnout

Thanks for your awesome node module!

This single commit should fix the issue with values starting with keywords such as OK, VALUE as mentioned here: 3rd-Eden#59.

The change includes escaping line breaks in values before set commands, and unescaping after get command.

I also added the following unit tests

  • Added unit tests for OK and for VALUE
  • Added unit test for checking correctly escaped line breaks

All unit tests pass after the change.

Please let me hear from you, if you have any questions.

Sebastian

Fixed issue with values starting with keywords such as OK, VALUE etc. (
…#59) by escaping line breaks in values before set commands, and unescaping after get command.

- Added unit tests for OK and for VALUE
- Added unit test for checking correctly escaped line breaks
@3rd-Eden

This comment has been minimized.

Show comment Hide comment
@3rd-Eden

3rd-Eden Nov 21, 2012

Owner

Hey,

Thanks a lot for the pull request and for creating the tests!

Owner

3rd-Eden commented Nov 21, 2012

Hey,

Thanks a lot for the pull request and for creating the tests!

3rd-Eden added a commit that referenced this pull request Nov 21, 2012

Merge pull request #71 from sebastianseilund/master
Fix for issue with values starting with OK, VALUE etc.

@3rd-Eden 3rd-Eden merged commit 5948538 into 3rd-Eden:master Nov 21, 2012

1 check passed

default The Travis build passed
Details
@sebastianseilund

This comment has been minimized.

Show comment Hide comment
@sebastianseilund

sebastianseilund Nov 26, 2012

Contributor

You're welcome! Let me know if there is anything else I can help with.

Contributor

sebastianseilund commented Nov 26, 2012

You're welcome! Let me know if there is anything else I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment