Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix shell not found error #202

Closed
wants to merge 1 commit into from
Closed

Conversation

tay
Copy link
Contributor

@tay tay commented Aug 4, 2014

When I run git commit in my iTerm, I get the following error message from the precommit hook:

> memcached@0.2.8 test /Users/Fiona/workspace/node-memcached
> mocha $(shell find test -name '*.test.js')

sh: shell: command not found

This PRs uses a regexp to find the test files instead of calling out to shell find.

Replace `shell find` with regexp.
@3rd-Eden 3rd-Eden closed this in 0f37954 Aug 6, 2014
@3rd-Eden
Copy link
Owner

3rd-Eden commented Aug 6, 2014

Thanks for your commit, i made small adjustment to your patch, I wanted to leave the find intact. Tests should still be working as intended now.

@tay tay deleted the fix-mocha-command branch August 6, 2014 21:48
@tay
Copy link
Contributor Author

tay commented Aug 6, 2014

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants